From: Wim Van Sebroeck <wim@iguana.be>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
David Dajun Chen <dchen@diasemi.com>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: da9055_wdt needs to select WATCHDOG_CORE
Date: Wed, 30 Jan 2013 20:23:30 +0100 [thread overview]
Message-ID: <20130130192330.GD20100@spo001.leaseweb.com> (raw)
In-Reply-To: <5106A77C.2050400@infradead.org>
Hi Randy,
> From: Randy Dunlap <rdunlap@infradead.org>
>
> DA9055_WATCHDOG needs to select WATCHDOG_CORE so that it will
> build cleanly. Fixes these build errors:
>
> da9055_wdt.c:(.text+0xe9bc7): undefined reference to `watchdog_unregister_device'
> da9055_wdt.c:(.text+0xe9f4b): undefined reference to `watchdog_register_device'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: David Dajun Chen <dchen@diasemi.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: linux-watchdog@vger.kernel.org
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Found in linux-next, but also applies to mainline.
>
> --- linux-next-20130128.orig/drivers/watchdog/Kconfig
> +++ linux-next-20130128/drivers/watchdog/Kconfig
> @@ -79,6 +79,7 @@ config DA9052_WATCHDOG
> config DA9055_WATCHDOG
> tristate "Dialog Semiconductor DA9055 Watchdog"
> depends on MFD_DA9055
> + select WATCHDOG_CORE
> help
> If you say yes here you get support for watchdog on the Dialog
> Semiconductor DA9055 PMIC.
Added to linux-watchdog-next.
Kind regards,
Wim.
prev parent reply other threads:[~2013-01-30 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 13:06 linux-next: Tree for Jan 28 Stephen Rothwell
2013-01-28 16:29 ` [PATCH] watchdog: da9055_wdt needs to select WATCHDOG_CORE Randy Dunlap
2013-01-30 19:23 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130192330.GD20100@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=dchen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox