Re: [PATCH] ASoC: fsl: Fix multiple symbol definitions

Thierry Reding
2013-01-31T07:07:05Z

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On Thu, Jan 31, 2013 at 09:42:17AM +0800, Shawn Guo wrote:
> On Wed, Jan 30, 2013 at 09:24:31PM +0100, Thierry Reding wrote:
> > Commit 25b8d31 (ASoC: fsl: fix multiple definition of init_module) fixed
> > a build error due to multiple symbol definitions when building as a
> > module. However, it causes the build to break when the driver is builtin
> > because the imx-pcm.o object is included multiple times. Solve the issue
> > by adding imx-pcm.o to each of the modules that require it, but only add
> > it to the kernel once when one or both drivers are builtin.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> Thanks, Thierry. The Kconfig is already complex. To avoid having them
> even more complex, I have chosen to revert my patch and have a little
> surgery on the code [1] to make it match the Kconfig rational.
>
> Shawn
>
> [1] http://thread.gmane.org/gmane.linux.alsa.devel/105018

That does indeed look much better than fiddling with the Makefile. My
automated ARM builds of linux-next were failing for a few days because
of this, so I guess the fix (as well as the MMC one) just hadn't made it
into linux-next yet.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]