From: Al Viro <viro@ZenIV.linux.org.uk>
To: chenggang.qin@gmail.com
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, David Ahern <dsahern@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Namhyung Kim <namhyung@gmail.com>,
Yanmin Zhang <yanmin.zhang@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Mike Galbraith <efault@gmx.de>,
Andrew Morton <akpm@linux-foundation.org>,
Chenggang Qin <chenggang.qcg@alibaba-inc.com>
Subject: Re: [PATCH v3] Add 4 tracepoint events for vfs
Date: Thu, 31 Jan 2013 07:50:10 +0000 [thread overview]
Message-ID: <20130131075010.GM4503@ZenIV.linux.org.uk> (raw)
In-Reply-To: <510a2020.654f420a.2872.7004@mx.google.com>
On Thu, Jan 31, 2013 at 03:40:38PM +0800, chenggang.qin@gmail.com wrote:
> @@ -1391,12 +1394,16 @@ generic_file_aio_read(struct kiocb *iocb, const struct iovec *iov,
> unsigned long seg = 0;
> size_t count;
> loff_t *ppos = &iocb->ki_pos;
> + const unsigned char *f_name;
>
> count = 0;
> retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
> if (retval)
> return retval;
>
> + f_name = filp->f_path.dentry->d_name.name;
> + trace_generic_file_aio_read(pos, iov_length(iov, nr_segs), f_name);
And just what is going to prevent that f_name of yours from being freed
just as you are passing it to the function you are calling?
IOW, NAK. BTW, I would like to point out that *ANY* hooks in VFS have all
the stability granted to driver API - removal fodder whenever it becomes
convenient.
prev parent reply other threads:[~2013-01-31 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 7:40 [PATCH v3] Add 4 tracepoint events for vfs chenggang.qin
2013-01-31 7:50 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131075010.GM4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=chenggang.qcg@alibaba-inc.com \
--cc=chenggang.qin@gmail.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox