From: Andrew Morton <akpm@linux-foundation.org>
To: xtu4 <xiaobing.tu@intel.com>
Cc: linux-kernel@vger.kernel.org, guifang.tang@intel.com,
linX.z.chen@intel.com
Subject: Re: resend----[PATCH] Avoid high order memory allocating with kmalloc, when read large seq file
Date: Thu, 31 Jan 2013 13:27:06 -0800 [thread overview]
Message-ID: <20130131132706.f15f3166.akpm@linux-foundation.org> (raw)
In-Reply-To: <510A0B14.70800@intel.com>
On Thu, 31 Jan 2013 14:11:32 +0800
xtu4 <xiaobing.tu@intel.com> wrote:
> [SEQ_FILE] Avoid high order memory allocating with kmalloc
> when read large seq file
The patch is still horridly mangled by your email client.
The implementation cheerfully ignores my earlier comment: "The
conventional way of doing this is to attempt the kmalloc with
__GFP_NOWARN and if that failed, fall back to vmalloc()."
This code has existed for ten years and this is the first time anyone
has encountered this problem. Rather than mucking around with the
seq_file code to attempt to fix this, it would be better to fix the
calling code.
next prev parent reply other threads:[~2013-01-31 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 6:14 Avoid high order memory allocating with kmalloc, when read large seq file xtu4
2013-01-29 21:49 ` David Rientjes
2013-01-31 6:19 ` Tu, Xiaobing
2013-01-30 0:24 ` Andrew Morton
2013-01-31 6:19 ` Tu, Xiaobing
2013-01-31 6:11 ` resend----[PATCH] " xtu4
2013-01-31 21:27 ` Andrew Morton [this message]
2013-02-01 3:30 ` xtu4
2013-02-01 3:31 ` xtu4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131132706.f15f3166.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=guifang.tang@intel.com \
--cc=linX.z.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaobing.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).