From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962Ab3AaOV0 (ORCPT ); Thu, 31 Jan 2013 09:21:26 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:33759 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753844Ab3AaOVY (ORCPT ); Thu, 31 Jan 2013 09:21:24 -0500 Date: Thu, 31 Jan 2013 14:21:17 +0000 From: Lee Jones To: Mark Brown Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file Message-ID: <20130131142117.GE2042@gmail.com> References: <1359635640-1932-1-git-send-email-lee.jones@linaro.org> <20130131123744.GG11078@opensource.wolfsonmicro.com> <20130131130340.GB2042@gmail.com> <20130131130631.GA12824@opensource.wolfsonmicro.com> <20130131140735.GD2042@gmail.com> <20130131141019.GA13321@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130131141019.GA13321@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Jan 2013, Mark Brown wrote: > On Thu, Jan 31, 2013 at 02:07:35PM +0000, Lee Jones wrote: > > On Thu, 31 Jan 2013, Mark Brown wrote: > > > > I'm a bit surprised the compiler would change something like that, I'd > > > expect it to be more the build system. > > > You've lost me. > > > When I compile this file it succeeds. When the person who reported > > this bug compiles, it fails with the error above. > > > mop500_ab8500.h is actually in the same directory as the file > > including it, so it should by rights be encapsulated in "" and not <>, > > right? > > Yes, it should - but this is also something that can be overridden by > the build system. It'd seem surprising for a compiler vendor to change > their behaviour here as there's limited benefit in changing and much > potential for error. Ah, got you. Are you going to take the patch? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog