* [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
@ 2013-01-31 12:34 Lee Jones
2013-01-31 12:37 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2013-01-31 12:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Lee Jones, Mark Brown
Some compilers complain when building sound for MOP500:
sound/soc/ux500/mop500.c:27:27:
fatal error: mop500_ab8500.h: No such file or directory
That file is actually in the local directory rather than include.
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/ux500/mop500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c
index ae69907..204b899 100644
--- a/sound/soc/ux500/mop500.c
+++ b/sound/soc/ux500/mop500.c
@@ -24,7 +24,7 @@
#include "ux500_pcm.h"
#include "ux500_msp_dai.h"
-#include <mop500_ab8500.h>
+#include "mop500_ab8500.h"
/* Define the whole MOP500 soundcard, linking platform to the codec-drivers */
struct snd_soc_dai_link mop500_dai_links[] = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 12:34 [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file Lee Jones
@ 2013-01-31 12:37 ` Mark Brown
2013-01-31 13:03 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2013-01-31 12:37 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
On Thu, Jan 31, 2013 at 12:34:00PM +0000, Lee Jones wrote:
> Some compilers complain when building sound for MOP500:
>
> sound/soc/ux500/mop500.c:27:27:
> fatal error: mop500_ab8500.h: No such file or directory
Should be kernel version dependant I expect...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 12:37 ` Mark Brown
@ 2013-01-31 13:03 ` Lee Jones
2013-01-31 13:06 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2013-01-31 13:03 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Thu, 31 Jan 2013, Mark Brown wrote:
> On Thu, Jan 31, 2013 at 12:34:00PM +0000, Lee Jones wrote:
> > Some compilers complain when building sound for MOP500:
> >
> > sound/soc/ux500/mop500.c:27:27:
> > fatal error: mop500_ab8500.h: No such file or directory
>
> Should be kernel version dependant I expect...
What do you mean?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 13:03 ` Lee Jones
@ 2013-01-31 13:06 ` Mark Brown
2013-01-31 14:07 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2013-01-31 13:06 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Thu, Jan 31, 2013 at 01:03:40PM +0000, Lee Jones wrote:
> On Thu, 31 Jan 2013, Mark Brown wrote:
> > On Thu, Jan 31, 2013 at 12:34:00PM +0000, Lee Jones wrote:
> > > Some compilers complain when building sound for MOP500:
> > > sound/soc/ux500/mop500.c:27:27:
> > > fatal error: mop500_ab8500.h: No such file or directory
> > Should be kernel version dependant I expect...
> What do you mean?
I'm a bit surprised the compiler would change something like that, I'd
expect it to be more the build system.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 13:06 ` Mark Brown
@ 2013-01-31 14:07 ` Lee Jones
2013-01-31 14:10 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2013-01-31 14:07 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Thu, 31 Jan 2013, Mark Brown wrote:
> On Thu, Jan 31, 2013 at 01:03:40PM +0000, Lee Jones wrote:
> > On Thu, 31 Jan 2013, Mark Brown wrote:
> > > On Thu, Jan 31, 2013 at 12:34:00PM +0000, Lee Jones wrote:
>
> > > > Some compilers complain when building sound for MOP500:
>
> > > > sound/soc/ux500/mop500.c:27:27:
> > > > fatal error: mop500_ab8500.h: No such file or directory
>
> > > Should be kernel version dependant I expect...
>
> > What do you mean?
>
> I'm a bit surprised the compiler would change something like that, I'd
> expect it to be more the build system.
You've lost me.
When I compile this file it succeeds. When the person who reported
this bug compiles, it fails with the error above.
mop500_ab8500.h is actually in the same directory as the file
including it, so it should by rights be encapsulated in "" and not <>,
right?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 14:07 ` Lee Jones
@ 2013-01-31 14:10 ` Mark Brown
2013-01-31 14:21 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2013-01-31 14:10 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On Thu, Jan 31, 2013 at 02:07:35PM +0000, Lee Jones wrote:
> On Thu, 31 Jan 2013, Mark Brown wrote:
> > I'm a bit surprised the compiler would change something like that, I'd
> > expect it to be more the build system.
> You've lost me.
> When I compile this file it succeeds. When the person who reported
> this bug compiles, it fails with the error above.
> mop500_ab8500.h is actually in the same directory as the file
> including it, so it should by rights be encapsulated in "" and not <>,
> right?
Yes, it should - but this is also something that can be overridden by
the build system. It'd seem surprising for a compiler vendor to change
their behaviour here as there's limited benefit in changing and much
potential for error.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 14:10 ` Mark Brown
@ 2013-01-31 14:21 ` Lee Jones
2013-01-31 14:33 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2013-01-31 14:21 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Thu, 31 Jan 2013, Mark Brown wrote:
> On Thu, Jan 31, 2013 at 02:07:35PM +0000, Lee Jones wrote:
> > On Thu, 31 Jan 2013, Mark Brown wrote:
>
> > > I'm a bit surprised the compiler would change something like that, I'd
> > > expect it to be more the build system.
>
> > You've lost me.
>
> > When I compile this file it succeeds. When the person who reported
> > this bug compiles, it fails with the error above.
>
> > mop500_ab8500.h is actually in the same directory as the file
> > including it, so it should by rights be encapsulated in "" and not <>,
> > right?
>
> Yes, it should - but this is also something that can be overridden by
> the build system. It'd seem surprising for a compiler vendor to change
> their behaviour here as there's limited benefit in changing and much
> potential for error.
Ah, got you.
Are you going to take the patch?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 14:21 ` Lee Jones
@ 2013-01-31 14:33 ` Mark Brown
2013-01-31 14:47 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2013-01-31 14:33 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
On Thu, Jan 31, 2013 at 02:21:17PM +0000, Lee Jones wrote:
> Are you going to take the patch?
Yes, I applied it when I sent the original reply.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file
2013-01-31 14:33 ` Mark Brown
@ 2013-01-31 14:47 ` Lee Jones
0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2013-01-31 14:47 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Thu, 31 Jan 2013, Mark Brown wrote:
> On Thu, Jan 31, 2013 at 02:21:17PM +0000, Lee Jones wrote:
>
> > Are you going to take the patch?
>
> Yes, I applied it when I sent the original reply.
Perfect, thanks Mark.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-01-31 14:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 12:34 [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missing include file Lee Jones
2013-01-31 12:37 ` Mark Brown
2013-01-31 13:03 ` Lee Jones
2013-01-31 13:06 ` Mark Brown
2013-01-31 14:07 ` Lee Jones
2013-01-31 14:10 ` Mark Brown
2013-01-31 14:21 ` Lee Jones
2013-01-31 14:33 ` Mark Brown
2013-01-31 14:47 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox