From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942Ab3BACMI (ORCPT ); Thu, 31 Jan 2013 21:12:08 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36484 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570Ab3BACMG (ORCPT ); Thu, 31 Jan 2013 21:12:06 -0500 Date: Thu, 31 Jan 2013 21:11:50 -0500 From: Konrad Rzeszutek Wilk To: Greg Kroah-Hartman , torvalds@linux-foundation.org Cc: Seth Jennings , devel@driverdev.osuosl.org, Dan Magenheimer , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Minchan Kim , Andrew Morton , Robert Jennings , Nitin Gupta Subject: Re: [PATCH] staging: zsmalloc: remove unused pool name Message-ID: <20130201021149.GB3416@konrad-lan.dumpdata.com> References: <1359560212-8818-1-git-send-email-sjenning@linux.vnet.ibm.com> <51093F43.2090503@linux.vnet.ibm.com> <20130130172159.GA24760@kroah.com> <20130130172956.GC2217@konrad-lan.dumpdata.com> <20130131053235.GD3228@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130131053235.GD3228@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > {sigh} you just made me have to edit your patch by hand, you now owe me > > > a beer... > > > > > Should we codify that :-) > > > > > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > > index c379a2a..f879c60 100644 > > --- a/Documentation/SubmittingPatches > > +++ b/Documentation/SubmittingPatches > > @@ -94,6 +94,7 @@ includes updates for subsystem X. Please apply." > > The maintainer will thank you if you write your patch description in a > > form which can be easily pulled into Linux's source code management > > system, git, as a "commit log". See #15, below. > > +If the maintainer has to hand-edit your patch, you owe them a beer. > > > > If your description starts to get long, that's a sign that you probably > > need to split up your patch. See #3, next. > > Yes we do need to codify this, but let's be fair, not everyone likes > beer: > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index c379a2a..d1bec01 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -93,7 +93,9 @@ includes updates for subsystem X. Please apply." > > The maintainer will thank you if you write your patch description in a > form which can be easily pulled into Linux's source code management > -system, git, as a "commit log". See #15, below. > +system, git, as a "commit log". See #15, below. If the maintainer has > +to hand-edit your patch, you owe them the beverage of their choice the > +next time you see them. > > If your description starts to get long, that's a sign that you probably > need to split up your patch. See #3, next. Does that mean you owe Linus a whiskey bottle since you didn't properly sign this patch :-)