From: Dan Carpenter <dan.carpenter@oracle.com>
To: Stratos Karafotis <stratosk@semaphore.gr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org,
Anton Vorontsov <anton.vorontsov@linaro.org>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Subject: Re: [PATCH] drivers: android: Restructure code in lowmemorykiller
Date: Fri, 1 Feb 2013 09:48:41 +0300 [thread overview]
Message-ID: <20130201064841.GB4937@mwanda> (raw)
In-Reply-To: <510AF4B0.7090002@semaphore.gr>
On Fri, Feb 01, 2013 at 12:48:16AM +0200, Stratos Karafotis wrote:
> I will fix it.
I don't know the status of this driver.
But in general the patch should have been divided up into smaller
changes and sent as a patchset. It creates a bunch of messy new
globals where it would have been cleaner to use function parameters.
Don't introduce new calls to lowmem_print() because we have better
debugging facilities already in the kernel and don't need more.
Btw, the more things you put into one patch, the more there is to
complain about and the less likely it is to be merged.
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-01 6:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 21:32 [PATCH] drivers: android: Restructure code in lowmemorykiller Stratos Karafotis
2013-01-31 22:25 ` Greg Kroah-Hartman
2013-01-31 22:48 ` Stratos Karafotis
2013-02-01 6:48 ` Dan Carpenter [this message]
2013-02-01 7:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201064841.GB4937@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anton.vorontsov@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=stratosk@semaphore.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox