From: Andrew Morton <akpm@linux-foundation.org>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: "GMEINER.Christian" <C.GMEINER@bachmann.info>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bryan Wu <cooloney@gmail.com>
Subject: Re: [PATCH] leds-ot200: Fix error caused by shifted mask
Date: Fri, 1 Feb 2013 14:12:11 -0800 [thread overview]
Message-ID: <20130201141211.1adadfe5.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAH9NwWdciqHSkkMSk4CW4XX+d6JSZBnvw52Svu8M4o-PGMQsDA@mail.gmail.com>
On Fri, 1 Feb 2013 16:08:15 +0100
Christian Gmeiner <christian.gmeiner@gmail.com> wrote:
> ping
Bryan is handling LEDs patches (see ./MAINTAINERS). Without a cc he
presumably missed this in the lkml flood.
> 2013/1/23 GMEINER.Christian <C.GMEINER@bachmann.info>:
> >> -----Urspr__ngliche Nachricht-----
> >> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
> >> Gesendet: Mittwoch, 23. Januar 2013 09:11
> >> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
> >> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
> >> Cc: Christian Gmeiner
> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
> >>
> >> During the development of this driver an in-house register documentation
> >> was used. The last weeks some integration tests were done and this problem
> >> was found. It turned out that the released register documentation is wrong.
> >>
> >> The fix is very simple: shift all masks by one.
> >>
The changelog failed to describe the effects of the bug it fixes. This
is a grave (and all too common) omission; it makes it difficult for
others to determine whether the patch should be backported into earlier
kernels.
So, please tell us. And feel free to explain whether you believe the
fix should be backported.
next prev parent reply other threads:[~2013-02-01 22:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 8:10 [PATCH] leds-ot200: Fix error caused by shifted mask Christian Gmeiner
2013-01-23 7:53 ` AW: " GMEINER.Christian
2013-02-01 15:08 ` Christian Gmeiner
2013-02-01 22:12 ` Andrew Morton [this message]
2013-02-04 14:46 ` Christian Gmeiner
2013-02-04 18:27 ` Bryan Wu
-- strict thread matches above, loose matches on Subject: below --
2012-12-06 13:21 Christian Gmeiner
2012-12-13 11:55 ` Christian Gmeiner
2012-12-17 8:13 ` Christian Gmeiner
2013-01-06 18:12 ` Christian Gmeiner
2012-10-01 12:50 Christian Gmeiner
2012-10-01 15:25 ` Greg KH
2012-10-12 6:20 ` Christian Gmeiner
2012-10-30 19:08 ` Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201141211.1adadfe5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=C.GMEINER@bachmann.info \
--cc=christian.gmeiner@gmail.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).