Re: [PATCH] Tracepoint: Add 'file name' as a parameter of tracepoint events ext4:ext4_direct_IO_enter&ext4:ext4_direct_IO_exit

["Theodore Ts'o" <tytso@mit.edu>]

On Fri, Feb 01, 2013 at 11:37:38PM +0800, chenggang.qin@gmail.com wrote:
> 
> Many database systems use their own page cache subsystems and use
> the direct IO to access the disks. Sometimes, the system engineers
> want to know the misses rate of the database system's page
> cache. They also require to know what files are accessed by the
> target processes with the direct IO method. These requirements can
> be satisfied by recording the database's file access behavior
> through the way of direct IO. So, we add 'file name' as a parameter
> of tracepoint events: ext4:ext4_direct_IO_enter &
> ext4:ext4_direct_IO_exit.

The device and inode number isn't sufficient?  Database files tend to
be long-lasting, so it shouldn't be hard to use the inode number.

My concern with putting the filename into the string buffer is that it
will seriously bloat the size of the event that will end up getting
dropped into the ring buffer.  

Regards,

						- Ted