From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Kent Yoder <shpedoikal@gmail.com>
Cc: Kent Yoder <key@linux.vnet.ibm.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Peter H?we <PeterHuewe@gmx.de>,
Mathias Leblanc <mathias.leblanc@st.com>
Subject: Re: [tpmdd-devel] [PATCH] TPM: Work around buggy TPMs that block during continue self test
Date: Fri, 1 Feb 2013 16:03:26 -0700 [thread overview]
Message-ID: <20130201230326.GA21081@obsidianresearch.com> (raw)
In-Reply-To: <CAM0nabE887HW1rk2Gu1+5iHk0_MS1iX8HCmDQBXmDkVtVgBNRA@mail.gmail.com>
On Fri, Feb 01, 2013 at 04:38:42PM -0600, Kent Yoder wrote:
> >> > https://github.com/shpedoikal/linux.git tpmdd-01-22-13
> >>
> >> Thanks Kent, I will try to test your branch next week, if I am able.
> >>
> >> Can you also grab
> >>
> >> https://github.com/jgunthorpe/linux/commit/98b2a198b43b41b0535200bf475160786398f114
> >
> > Thanks, I missed this, I'll start testing it.
>
> Ok, after yet another round of fixes to the stm i2c driver, I have a
> staging tree. I'll submit this as-is next week unless something super
> ground-breaking comes up.
Great, I'll put this on my list..
I didn't receive your prior message, thank you for quoting it..
> >> https://github.com/jgunthorpe/linux/commit/9981e3e622bf702394982117134bed731ffd6f7e
> >
> > This one is a bit out of date atm, for instance the __dev* stuff is
> > going away. The thing that most makes me hesitant though is the config
> > if (X86 || OF). A hardware platform or a firmware type.. What platform
> > should this actually target?
Right on the __dev stuff..
Well the 'depends on' buisness is only due to the unconditional
probing of TIS_MEM_BASE for a tpm, and then the autodetection of an
IRQ number. That procedure is very much X86 only.
My patch removes the unconditional probe when OF support is turned on,
so it is safe to use on any platform only when OF is enabled.
Yes it is really wonky, but unconditionally probing HW in a driver is
wonky these days too..
Jason
next prev parent reply other threads:[~2013-02-01 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 21:15 [PATCH] TPM: Work around buggy TPMs that block during continue self test Jason Gunthorpe
2013-01-22 23:29 ` [tpmdd-devel] " Kent Yoder
2013-01-25 20:25 ` Jason Gunthorpe
[not found] ` <20130128141153.GA3060@ennui.austin.ibm.com>
2013-02-01 22:38 ` Kent Yoder
2013-02-01 23:03 ` Jason Gunthorpe [this message]
2013-02-03 23:02 ` Peter Hüwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201230326.GA21081@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=PeterHuewe@gmx.de \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.leblanc@st.com \
--cc=shpedoikal@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).