Re: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device

Ben Hutchings
2013-02-06T04:21:12Z

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

On Mon, 2013-02-04 at 16:36 -0800, Bing Zhao wrote:
> Hi Ben,
>
> > On Mon, 2013-02-04 at 11:43 -0800, Bing Zhao wrote:
> > > Hi Ben,
> > >
> > > > 3.2-stable review patch. If anyone has any objections, please let me know.
> > > >
> > > > ------------------
> > > >
> > > > From: Avinash Patil <patila@marvell.com>
> > > >
> > > > commit bbea3bc432dc5c08d09ca5c80afdd82515470688 upstream.
> > >
> > > This patch is not for stable kernel.
> > [...]
> >
> > Right, I've managed to pick up 3 changes to mwifiex that it looks like I
> > shouldn't have included. Firstly:
> >
> > 9c969d8ccb1e mwifiex: check wait_event_interruptible return value
> >
> > This had "3.6+" to the left of <stable@vger.kernel.org>, whereas I
> > expect version qualifiers to be on the right. So my import script just
> > put this in the queue without asking me to interpret the version
> > qualifier. (I don't automate *that* because people use too wide a
> > variety of syntaxes.)
>
> Sorry. From now on I will put version qualifiers on the right side of <stable@vger...>
>
> >
> > When trying to apply that, I found that it seemed to depend on these
> > two:
> >
> > bbea3bc432dc mwifiex: wakeup and stop multiple tx queues in net_device
>
> I'd rather classify this patch as an enhancement because the code change is relatively large.
> To play it safe, let's drop this patch from -stable.
>
> > b7097eb75fa1 mwifiex: handle association failure case correctly
>
> This is a bug fix indeed.
>
> >
> > which also looked like they were important fixes. Presumably I should
> > drop all of those?
>
> Please drop bbea3bc432dc only.
>
> I can resend a backport of "b7097eb75fa1 mwifiex: handle association failure case correctly" for 3.2-stable.

Thanks, I've made these two changes.

Ben.

--
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
- Albert Einstein

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]