public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Clark Williams <williams@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 2/2] sched/rt:  add a tuning knob to allow changing SCHED_RR timeslice
Date: Sun, 3 Feb 2013 19:57:09 +0100	[thread overview]
Message-ID: <20130203185709.GA22826@gmail.com> (raw)
In-Reply-To: <20130203111025.GC11739@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> The first patch looks good, I've applied it.

I've skipped this one after all, as it sometimes generates:

include/linux/sched/sysctl.h:108:41: warning: ‘struct signal_struct’ declared inside parameter list [enabled by default]

Sometimes doesn't built kernel/sched/auto_group.c. So those bits 
probably want to move into a separate sched/auto_group.h header 
or so.

But, more fundamentally, I think sched.h should not include the 
new sched/sysctl.h file. The whole point is to move out bits 
from sched.h and decouple them from sched.h - to shrink sched.h 
in the long run.

Thanks,

	Ingo

  reply	other threads:[~2013-02-03 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31 19:52 [PATCHv2 2/2] sched/rt: add a tuning knob to allow changing SCHED_RR timeslice Clark Williams
2013-02-03 11:10 ` Ingo Molnar
2013-02-03 18:57   ` Ingo Molnar [this message]
2013-02-04  2:03     ` Clark Williams
2013-02-04 11:01       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130203185709.GA22826@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox