* [PATCH] asmlinkage tag for sys_iopl
@ 2013-02-03 12:46 Artem Savkov
2013-02-03 18:59 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Artem Savkov @ 2013-02-03 12:46 UTC (permalink / raw)
To: x86, linux-kernel; +Cc: Al Viro, Artem Savkov
asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
9e0b2428bc6a6c6df90bb701ca843820727cadf0.
Signed-off-by: Artem Savkov <artem.savkov@gmail.com>
---
arch/x86/include/asm/syscalls.h | 2 +-
arch/x86/kernel/ioport.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/syscalls.h b/arch/x86/include/asm/syscalls.h
index 13f078c..6cf0a9c 100644
--- a/arch/x86/include/asm/syscalls.h
+++ b/arch/x86/include/asm/syscalls.h
@@ -18,7 +18,7 @@
/* Common in X86_32 and X86_64 */
/* kernel/ioport.c */
asmlinkage long sys_ioperm(unsigned long, unsigned long, int);
-long sys_iopl(unsigned int);
+asmlinkage long sys_iopl(unsigned int);
/* kernel/ldt.c */
asmlinkage int sys_modify_ldt(int, void __user *, unsigned long);
diff --git a/arch/x86/kernel/ioport.c b/arch/x86/kernel/ioport.c
index 5f98381..b1127a0 100644
--- a/arch/x86/kernel/ioport.c
+++ b/arch/x86/kernel/ioport.c
@@ -93,7 +93,7 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on)
* on system-call entry - see also fork() and the signal handling
* code.
*/
-long sys_iopl(unsigned int level)
+asmlinkage long sys_iopl(unsigned int level)
{
struct pt_regs *regs = current_pt_regs();
unsigned int old = (regs->flags >> 12) & 3;
--
1.8.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] asmlinkage tag for sys_iopl
2013-02-03 12:46 [PATCH] asmlinkage tag for sys_iopl Artem Savkov
@ 2013-02-03 18:59 ` Ingo Molnar
2013-02-03 19:04 ` Al Viro
0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2013-02-03 18:59 UTC (permalink / raw)
To: Artem Savkov; +Cc: x86, linux-kernel, Al Viro
* Artem Savkov <artem.savkov@gmail.com> wrote:
> asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
> syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
> 9e0b2428bc6a6c6df90bb701ca843820727cadf0.
What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's
certainly not upstream nor in the x86 tree.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] asmlinkage tag for sys_iopl
2013-02-03 18:59 ` Ingo Molnar
@ 2013-02-03 19:04 ` Al Viro
2013-02-03 19:06 ` Ingo Molnar
2013-02-03 19:44 ` Artem Savkov
0 siblings, 2 replies; 6+ messages in thread
From: Al Viro @ 2013-02-03 19:04 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Artem Savkov, x86, linux-kernel
On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote:
>
> * Artem Savkov <artem.savkov@gmail.com> wrote:
>
> > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
> > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
> > 9e0b2428bc6a6c6df90bb701ca843820727cadf0.
>
> What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's
> certainly not upstream nor in the x86 tree.
It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it
tonight.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] asmlinkage tag for sys_iopl
2013-02-03 19:04 ` Al Viro
@ 2013-02-03 19:06 ` Ingo Molnar
2013-02-03 19:44 ` Artem Savkov
1 sibling, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2013-02-03 19:06 UTC (permalink / raw)
To: Al Viro; +Cc: Artem Savkov, x86, linux-kernel
* Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote:
> >
> > * Artem Savkov <artem.savkov@gmail.com> wrote:
> >
> > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
> > > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
> > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0.
> >
> > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's
> > certainly not upstream nor in the x86 tree.
>
> It's in signal.git; proper fix is to use SYSCALL_DEFINE1().
> I'll push it tonight.
Thanks!
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] asmlinkage tag for sys_iopl
2013-02-03 19:04 ` Al Viro
2013-02-03 19:06 ` Ingo Molnar
@ 2013-02-03 19:44 ` Artem Savkov
2013-02-04 15:21 ` Al Viro
1 sibling, 1 reply; 6+ messages in thread
From: Artem Savkov @ 2013-02-03 19:44 UTC (permalink / raw)
To: Al Viro; +Cc: Ingo Molnar, x86, linux-kernel
On Sun, Feb 03, 2013 at 07:04:35PM +0000, Al Viro wrote:
> On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote:
> >
> > * Artem Savkov <artem.savkov@gmail.com> wrote:
> >
> > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
> > > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
> > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0.
> >
> > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's
> > certainly not upstream nor in the x86 tree.
>
> It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it
> tonight.
It is also in linux-next.git, so it would be nice to have a fix merged
there too.
Thanks.
--
Kind regards,
Artem
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] asmlinkage tag for sys_iopl
2013-02-03 19:44 ` Artem Savkov
@ 2013-02-04 15:21 ` Al Viro
0 siblings, 0 replies; 6+ messages in thread
From: Al Viro @ 2013-02-04 15:21 UTC (permalink / raw)
To: Artem Savkov; +Cc: Ingo Molnar, x86, linux-kernel
On Sun, Feb 03, 2013 at 11:44:22PM +0400, Artem Savkov wrote:
> On Sun, Feb 03, 2013 at 07:04:35PM +0000, Al Viro wrote:
> > On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote:
> > >
> > > * Artem Savkov <artem.savkov@gmail.com> wrote:
> > >
> > > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
> > > > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
> > > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0.
> > >
> > > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's
> > > certainly not upstream nor in the x86 tree.
> >
> > It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it
> > tonight.
>
> It is also in linux-next.git, so it would be nice to have a fix merged
> there too.
> Thanks.
linux-next pulls signal.git, which is how that commit has appeared there
in the first place...
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-04 15:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-03 12:46 [PATCH] asmlinkage tag for sys_iopl Artem Savkov
2013-02-03 18:59 ` Ingo Molnar
2013-02-03 19:04 ` Al Viro
2013-02-03 19:06 ` Ingo Molnar
2013-02-03 19:44 ` Artem Savkov
2013-02-04 15:21 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox