From: Ingo Molnar <mingo@kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Artem Savkov <artem.savkov@gmail.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asmlinkage tag for sys_iopl
Date: Sun, 3 Feb 2013 20:06:23 +0100 [thread overview]
Message-ID: <20130203190623.GA23021@gmail.com> (raw)
In-Reply-To: <20130203190435.GS4503@ZenIV.linux.org.uk>
* Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Sun, Feb 03, 2013 at 07:59:12PM +0100, Ingo Molnar wrote:
> >
> > * Artem Savkov <artem.savkov@gmail.com> wrote:
> >
> > > asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl
> > > syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in
> > > 9e0b2428bc6a6c6df90bb701ca843820727cadf0.
> >
> > What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's
> > certainly not upstream nor in the x86 tree.
>
> It's in signal.git; proper fix is to use SYSCALL_DEFINE1().
> I'll push it tonight.
Thanks!
Ingo
next prev parent reply other threads:[~2013-02-03 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 12:46 [PATCH] asmlinkage tag for sys_iopl Artem Savkov
2013-02-03 18:59 ` Ingo Molnar
2013-02-03 19:04 ` Al Viro
2013-02-03 19:06 ` Ingo Molnar [this message]
2013-02-03 19:44 ` Artem Savkov
2013-02-04 15:21 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203190623.GA23021@gmail.com \
--to=mingo@kernel.org \
--cc=artem.savkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox