From: Dan Carpenter <dan.carpenter@oracle.com>
To: Roger Tseng <rogerable@realtek.com>
Cc: cjb@laptop.org, sameo@linux.intel.com,
gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
devel@linuxdriverproject.org
Subject: Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment
Date: Mon, 4 Feb 2013 11:47:37 +0300 [thread overview]
Message-ID: <20130204084737.GG4937@mwanda> (raw)
In-Reply-To: <1359963959-2305-2-git-send-email-rogerable@realtek.com>
On Mon, Feb 04, 2013 at 03:45:57PM +0800, Roger Tseng wrote:
> Several new models of readers use different way to select driving
> capability(a necessary adjustment along with voltage change). Removing this
> from device-independent rtsx_pci_sdmmc module. It will be implemented in
> device-depend calls encapsulated by rtsx_pci_switch_output_voltage().
>
I'm not sure I understand.
Does this patch break things and then "[PATCH 2/3] mfd: rtsx:
implement driving adjustment to device-dependent callbacks" fixes
things again? In other words, will all the old devices run if we
only apply patch 1/3 and not 2/3?
That's not the right idea. Just merge the two patches into one
patch.
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-04 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 7:45 [PATCH 0/3] rtsx: patchset for supporting new model RTS5227 Roger Tseng
2013-02-04 7:45 ` [PATCH 1/3] MMC: rtsx: remove driving adjustment Roger Tseng
2013-02-04 8:47 ` Dan Carpenter [this message]
2013-02-05 2:51 ` Roger Tseng
2013-02-05 8:30 ` Dan Carpenter
2013-02-11 17:53 ` Chris Ball
2013-02-04 7:45 ` [PATCH 2/3] mfd: rtsx: implement driving adjustment to device-dependent callbacks Roger Tseng
2013-02-04 11:56 ` Samuel Ortiz
2013-02-04 7:45 ` [PATCH 3/3] mfd: rtsx: support RTS5227 Roger Tseng
2013-02-04 11:57 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204084737.GG4937@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox