From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754108Ab3BDIr5 (ORCPT ); Mon, 4 Feb 2013 03:47:57 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29230 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753691Ab3BDIr4 (ORCPT ); Mon, 4 Feb 2013 03:47:56 -0500 Date: Mon, 4 Feb 2013 11:47:37 +0300 From: Dan Carpenter To: Roger Tseng Cc: cjb@laptop.org, sameo@linux.intel.com, gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn, devel@linuxdriverproject.org Subject: Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment Message-ID: <20130204084737.GG4937@mwanda> References: <1359963959-2305-1-git-send-email-rogerable@realtek.com> <1359963959-2305-2-git-send-email-rogerable@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1359963959-2305-2-git-send-email-rogerable@realtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 04, 2013 at 03:45:57PM +0800, Roger Tseng wrote: > Several new models of readers use different way to select driving > capability(a necessary adjustment along with voltage change). Removing this > from device-independent rtsx_pci_sdmmc module. It will be implemented in > device-depend calls encapsulated by rtsx_pci_switch_output_voltage(). > I'm not sure I understand. Does this patch break things and then "[PATCH 2/3] mfd: rtsx: implement driving adjustment to device-dependent callbacks" fixes things again? In other words, will all the old devices run if we only apply patch 1/3 and not 2/3? That's not the right idea. Just merge the two patches into one patch. regards, dan carpenter