* [PATCH] regulator: palmas: Remove a redundant setting for warm_reset
@ 2013-02-03 12:49 Axel Lin
2013-02-04 10:24 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-02-03 12:49 UTC (permalink / raw)
To: Mark Brown; +Cc: Graeme Gregory, Liam Girdwood, linux-kernel
Current code read "ti,warm_reset" of property twice, and set
pdata->reg_init[idx]->warm_reset twice. Read and set it once is enough.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/palmas-regulator.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index cbaf226..cde13bb 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -568,11 +568,6 @@ static void palmas_dt_to_pdata(struct device *dev,
pdata->reg_init[idx]->mode_sleep = prop;
ret = of_property_read_u32(palmas_matches[idx].of_node,
- "ti,warm_reset", &prop);
- if (!ret)
- pdata->reg_init[idx]->warm_reset = prop;
-
- ret = of_property_read_u32(palmas_matches[idx].of_node,
"ti,tstep", &prop);
if (!ret)
pdata->reg_init[idx]->tstep = prop;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: palmas: Remove a redundant setting for warm_reset
2013-02-03 12:49 [PATCH] regulator: palmas: Remove a redundant setting for warm_reset Axel Lin
@ 2013-02-04 10:24 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-02-04 10:24 UTC (permalink / raw)
To: Axel Lin; +Cc: Graeme Gregory, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
On Sun, Feb 03, 2013 at 08:49:56PM +0800, Axel Lin wrote:
> Current code read "ti,warm_reset" of property twice, and set
> pdata->reg_init[idx]->warm_reset twice. Read and set it once is enough.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-04 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-03 12:49 [PATCH] regulator: palmas: Remove a redundant setting for warm_reset Axel Lin
2013-02-04 10:24 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox