From: Ingo Molnar <mingo@kernel.org>
To: Sasha Levin <sasha.levin@oracle.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: mingo@redhat.com, peterz@infradead.org, paulus@samba.org,
acme@ghostprotocols.net, penberg@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/7] liblockdep: wrap kernel/lockdep.c to allow usage from userspace
Date: Mon, 4 Feb 2013 11:48:46 +0100 [thread overview]
Message-ID: <20130204104845.GB24173@gmail.com> (raw)
In-Reply-To: <1359942644-26371-1-git-send-email-sasha.levin@oracle.com>
Ok, these liblockdep bits look really good and clean, and the
perf integration is obviously useful. It does not conflict with
any pending tools/perf work either.
Arnaldo, are you fine with:
b2e7c77a3790 perf: Integrate liblockdep support into perf
?
We could keep it separate in tip:core/locking, no merge into
tip:perf/core appears to be necessary for the time being.
A couple of suggestions:
1) One thing that is I think is missing is a fun to read
tools/lib/lockdep/README that explains how to use it all for
pthread_mutex_t and pthread_rwlock_t checking, and what the
limitations are (if any).
2) Explicitly mentioning that the code and library is licensed
under the kernel's GPL would be nice as well, for additional
clarity - should anyone decide to package it up in distros.
3) Advanced: providing a shell environment variable (LOCKDEP=1?)
as a way to enable it might be useful as well: that way tools
could be built with lockdep built in but turned off by default -
which can be turned on again on demand. It would only constitute
some data structure overhead, a runtime check in the locking
wrappers and a bit of an initialization overhead.
Thanks,
Ingo
next prev parent reply other threads:[~2013-02-04 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 1:50 [PATCH v3 1/7] liblockdep: wrap kernel/lockdep.c to allow usage from userspace Sasha Levin
2013-02-04 1:50 ` [PATCH v3 2/7] liblockdep: public headers for mutex implementation Sasha Levin
2013-02-04 13:51 ` [tip:core/locking] liblockdep: Add public headers for pthread_mutex_t implementation tip-bot for Sasha Levin
2013-02-04 1:50 ` [PATCH v3 3/7] liblockdep: mutex test suite Sasha Levin
2013-02-04 13:52 ` [tip:core/locking] liblockdep: Add pthread_mutex_t " tip-bot for Sasha Levin
2013-02-04 1:50 ` [PATCH v3 4/7] liblockdep: public headers for rwlock implementation Sasha Levin
2013-02-04 13:53 ` [tip:core/locking] liblockdep: Add public headers for pthread_rwlock_t implementation tip-bot for Sasha Levin
2013-02-04 1:50 ` [PATCH v3 5/7] liblockdep: rwlock test suite Sasha Levin
2013-02-04 13:55 ` [tip:core/locking] liblockdep: Add pthread_rwlock_t " tip-bot for Sasha Levin
2013-02-04 1:50 ` [PATCH v3 6/7] liblockdep: add a MAINTAINERS entry Sasha Levin
2013-02-04 13:56 ` [tip:core/locking] liblockdep: Add " tip-bot for Sasha Levin
2013-02-04 1:50 ` [PATCH v3 7/7] perf: integrate liblockdep support into perf Sasha Levin
2013-02-04 13:57 ` [tip:core/locking] perf: Integrate " tip-bot for Sasha Levin
2013-02-21 17:16 ` [PATCH] perf: define LIBLOCKDEP_LIBS to fix linker errors Dongsu Park
2013-02-04 10:48 ` Ingo Molnar [this message]
2013-02-04 13:48 ` [tip:core/locking] liblockdep: Wrap kernel/ lockdep.c to allow usage from userspace tip-bot for Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204104845.GB24173@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=acme@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).