From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754966Ab3BDNCS (ORCPT ); Mon, 4 Feb 2013 08:02:18 -0500 Received: from 8bytes.org ([85.214.48.195]:33752 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754547Ab3BDNCR (ORCPT ); Mon, 4 Feb 2013 08:02:17 -0500 Date: Mon, 4 Feb 2013 14:02:14 +0100 From: Joerg Roedel To: Sethi Varun-B16395 Cc: "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Wood Scott-B07421 , Yoder Stuart-B08248 Subject: Re: [PATCH 4/4] iommu: Add domain window handling functions Message-ID: <20130204130214.GN25591@8bytes.org> References: <1359582228-21552-1-git-send-email-joro@8bytes.org> <1359582228-21552-5-git-send-email-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Mon Feb 4 14:02:15 2013 X-DSPAM-Confidence: 0.9994 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 510fb15722971699272620 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 31, 2013 at 09:32:26AM +0000, Sethi Varun-B16395 wrote: > We need a mechanism to determine the maximum number of subwindows supported by PAMU. How about representing it in the iommu_domain structure: > struct iommu_domain { > struct iommu_ops *ops; > void *priv; > iommu_fault_handler_t handler; > void *handler_token; > struct iommu_domain_geometry geometry; > u32 max_sub_windows; -----> maximum number of sub windows supported by the hardware. > } I`ll leave that flag to the private-data of the IOMMU domain. Instead I added a DOMAIN_ATTR_WINDOWS attribute to get/set the number of subwindows. I'll post the updated patch-set soon. Joerg