From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: Re: [PATCH] rcu: Have rcu torture test select trace_clock
Date: Mon, 4 Feb 2013 08:59:32 -0800 [thread overview]
Message-ID: <20130204165932.GW2632@linux.vnet.ibm.com> (raw)
In-Reply-To: <1359993141.5642.61.camel@gandalf.local.home>
On Mon, Feb 04, 2013 at 10:52:21AM -0500, Steven Rostedt wrote:
> The rcu torture test uses trace_clock, and requires that it be built
> into the kernel. If it is not, then we get the following build error:
>
> ERROR: "trace_clock_local" [kernel/rcutorture.ko] undefined!
>
> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This would work, but would unnecessarily force trace_clock_local()
to be defined when RCU tracing is disabled. So, would the alternative
patch I posted work for you?
Thanx, Paul
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4057127..b542477 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -942,6 +942,7 @@ config SPARSE_RCU_POINTER
> config RCU_TORTURE_TEST
> tristate "torture tests for RCU"
> depends on DEBUG_KERNEL
> + select TRACE_CLOCK
> default n
> help
> This option provides a kernel module that runs torture tests
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2013-02-04 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 15:52 [PATCH] rcu: Have rcu torture test select trace_clock Steven Rostedt
2013-02-04 16:59 ` Paul E. McKenney [this message]
2013-02-04 18:36 ` Steven Rostedt
2013-02-04 18:59 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204165932.GW2632@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox