From: David Teigland <teigland@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Sasha Levin <levinsasha928@gmail.com>
Subject: [GIT PULL] Revert "dlm: check the maximum size of a request from user"
Date: Mon, 4 Feb 2013 12:06:55 -0500 [thread overview]
Message-ID: <20130204170655.GA20950@redhat.com> (raw)
Hi Linus,
Please pull the following fix from branch:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git for-linus
This reverts commit 2b75bc9121e54e22537207b47b71373bcb0be41c.
There is something wrong with the CONFIG_COMPAT max size
check in ioctl write. There is a report of a case where
this breaks userland (clvmd) when maximum resource name
lengths are used. I am still sorting out exactly which
combinations of kernel and userland libs are a problem.
Reported-by: Jana Saout <jana@saout.de>
CC: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/dlm/user.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index 7ff4985..eb4ed9b 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -503,13 +503,6 @@ static ssize_t device_write(struct file *file, const char __user *buf,
#endif
return -EINVAL;
-#ifdef CONFIG_COMPAT
- if (count > sizeof(struct dlm_write_request32) + DLM_RESNAME_MAXLEN)
-#else
- if (count > sizeof(struct dlm_write_request) + DLM_RESNAME_MAXLEN)
-#endif
- return -EINVAL;
-
kbuf = kzalloc(count + 1, GFP_NOFS);
if (!kbuf)
return -ENOMEM;
--
1.8.1.rc1.5.g7e0651a
next reply other threads:[~2013-02-04 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 17:06 David Teigland [this message]
2013-02-04 20:19 ` [GIT PULL] Revert "dlm: check the maximum size of a request from user" Sasha Levin
2013-02-04 20:36 ` David Teigland
2013-02-04 21:49 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204170655.GA20950@redhat.com \
--to=teigland@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox