From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Kurachkin Michail <Michail.Kurachkin@promwad.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kuten Ivan <Ivan.Kuten@promwad.com>,
"benavi@marvell.com" <benavi@marvell.com>,
Palstsiuk Viktar <Viktar.Palstsiuk@promwad.com>
Subject: Re: TDM bus support in Linux Kernel [PATCH]
Date: Mon, 4 Feb 2013 15:49:16 -0800 [thread overview]
Message-ID: <20130204234916.GB11239@kroah.com> (raw)
In-Reply-To: <511044C9.9090809@gmail.com>
On Tue, Feb 05, 2013 at 10:31:21AM +1100, Ryan Mallon wrote:
> On 30/01/13 23:37, Kurachkin Michail wrote:
> > Hi Greg,
> >
> > I followed your recommendations and created a diff using Linux 3.8-rc5 sources. Please review it and give your comments.
> >
> >
>
> Hi Kurachkin,
>
> Below is a quick skim-through review (of about 70% of the code). I've
> not really commented on the design, mostly just on coding style and
> small bugs. For patch-sets of this size, can you please break them down
> into multiple small patches, and please post patches inline which make
> reviewing easier.
Those types of changes can all be done after the code is in the
drivers/staging/ tree, and are not a barrier for acceptance at this
point in time.
thanks,
greg k-h
prev parent reply other threads:[~2013-02-04 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:37 TDM bus support in Linux Kernel [PATCH] Kurachkin Michail
2013-01-30 12:59 ` Oliver Neukum
2013-02-04 13:08 ` Re[2]: " Michail Kurachkin
2013-02-05 15:34 ` Oliver Neukum
2013-02-13 17:08 ` Re[2]: " Michail Kurachkin
2013-02-14 12:46 ` Ivan Kuten
2013-01-30 13:03 ` Oliver Neukum
2013-01-30 13:28 ` Oliver Neukum
2013-01-30 13:35 ` Oliver Neukum
2013-01-30 13:43 ` Oliver Neukum
2013-01-30 15:57 ` Greg Kroah-Hartman
[not found] ` <511044C9.9090809@gmail.com>
2013-02-04 23:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204234916.GB11239@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Ivan.Kuten@promwad.com \
--cc=Michail.Kurachkin@promwad.com \
--cc=Viktar.Palstsiuk@promwad.com \
--cc=benavi@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox