From: Jason Cooper <jason@lakedaemon.net>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include
Date: Tue, 5 Feb 2013 10:34:11 -0500 [thread overview]
Message-ID: <20130205153411.GV14746@titan.lakedaemon.net> (raw)
In-Reply-To: <1360077025-8046-1-git-send-email-thierry.reding@avionic-design.de>
Thierry,
On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> of which are defined in the linux/i2c.h header file.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
> arch/arm/mach-kirkwood/board-nsa310.c | 1 +
> 1 file changed, 1 insertion(+)
What is this based against? We're in the process of removing this whole
file for v3.9 (pinctrl, mv643xx_eth, and i2c)...
thx,
Jason.
>
> diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
> index 61c4b18..970174a 100644
> --- a/arch/arm/mach-kirkwood/board-nsa310.c
> +++ b/arch/arm/mach-kirkwood/board-nsa310.c
> @@ -11,6 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/gpio.h>
> +#include <linux/i2c.h>
> #include <mach/kirkwood.h>
> #include <linux/of.h>
> #include "common.h"
> --
> 1.8.1.2
>
next prev parent reply other threads:[~2013-02-05 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 15:10 [PATCH] ARM: Kirkwood: Add missing linux/i2c.h include Thierry Reding
2013-02-05 15:34 ` Jason Cooper [this message]
2013-02-05 15:38 ` Thierry Reding
2013-02-05 15:52 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205153411.GV14746@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox