From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756876Ab3BFBU7 (ORCPT ); Tue, 5 Feb 2013 20:20:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43233 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756466Ab3BFBU6 (ORCPT ); Tue, 5 Feb 2013 20:20:58 -0500 Date: Tue, 5 Feb 2013 17:20:56 -0800 From: Andrew Morton To: Zhang Yanfei Cc: Johannes Weiner , Zhang Yanfei , Linux MM , mgorman@suse.de, minchan@kernel.org, kamezawa.hiroyu@jp.fujitsu.com, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] mm: rename confusing function names Message-Id: <20130205172057.3be4dbd4.akpm@linux-foundation.org> In-Reply-To: <5111AC7D.9070505@cn.fujitsu.com> References: <51113CE3.5090000@gmail.com> <20130205192640.GC6481@cmpxchg.org> <20130205141332.04fcceac.akpm@linux-foundation.org> <5111AC7D.9070505@cn.fujitsu.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Feb 2013 09:06:05 +0800 Zhang Yanfei wrote: > So could I rename the functions to the names like > nr_available_buffer_high_pages > And accurately document them with code comments just as you suggested. gee. "available" implies "available for you to allocate". It has the same problem as "free". And "buffer" shouldn't be there - that's a reflection of the fact that buffer_head payloads are not allocated from highmem. An archaic irrelevant thing. Seriously, first let's write down the descriptions of what these functions *do*. Then choose nice names which abbreviate that. hm, static unsigned int nr_free_zone_pages(int offset) { ... unsigned int sum = 0; ... return sum; } How long will it be until these things start exploding from sums-of-zones which exceed 16TB?