From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756528Ab3BESXM (ORCPT ); Tue, 5 Feb 2013 13:23:12 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:39213 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753934Ab3BESXL (ORCPT ); Tue, 5 Feb 2013 13:23:11 -0500 Date: Tue, 5 Feb 2013 13:23:01 -0500 From: Johannes Weiner To: Konstantin Khlebnikov Cc: Andrew Morton , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch] mm: shmem: use new radix tree iterator Message-ID: <20130205182301.GD993@cmpxchg.org> References: <1359699238-7327-1-git-send-email-hannes@cmpxchg.org> <510CCD88.30200@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <510CCD88.30200@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 02, 2013 at 12:25:44PM +0400, Konstantin Khlebnikov wrote: > Johannes Weiner wrote: > >In shmem_find_get_pages_and_swap, use the faster radix tree iterator > >construct from 78c1d78 "radix-tree: introduce bit-optimized iterator". > > > >Signed-off-by: Johannes Weiner > > Hmm, ACK. shmem_unuse_inode() also can be redone in this way. > I did something similar year ago: https://lkml.org/lkml/2012/2/10/388 > As result we can rid of radix_tree_locate_item() and shmem_find_get_pages_and_swap() I remember your patches and am working on a totally unrelated series that also gets rid of shmem_find_get_pages_and_swap(). Either way, this thing's going down, so just I didn't bother with the conversion.