Re: [PATCH 10/13] workqueue: add lock_pool_own_work() and remove get_work_pool()

Tejun Heo
2013-02-04T21:38:57Z

On Fri, Feb 01, 2013 at 02:41:33AM +0800, Lai Jiangshan wrote:
> lock_pool_own_work() reuse lock_pool_queued_work() and lock_pool_executing_work()
> to implement "get the correct own pool and lock" logic. It makes all callings
> to lock_pool_own_work()'s mean/logic are more clear.
>
> get_work_pool() can't get the really pool which owns the work
> and it is not used any more, just remove it.
>
> Add/Use proper locking API.

I like they're being collected into one interface although the name
seems a bit iffy to me. Maybe mark the original two functions as
internal to the new locking interface?

Thanks.

--
tejun