Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

Federico Vaga
2013-02-06T14:26:19Z

Hi Hans,

thank you very much for your review and your patience.

> OK, I'm going to give this my Acked-by, but I really wish you would
> have split this up into smaller changes. It's hard to review since
> you have made so many changes in this one patch. Even though I'm
> giving my ack, Mauro might decide against it, so if you have time
> to spread out the changes in multiple patches, then please do so.

I tried to do smaller patch but there is always some incoherent part
and the driver cannot work without all the patches. I should write
some "fake" patches to make a coherent series.
I reduce the size of the patch since v4/5; I leaved
unchanged some code/comments to simplify the patch.

> So, given the fact that this changes just a single driver not
> commonly used in existing deployments, assuming that you have
> tested the changes (you did that, right? Just checking...), that
> these are really useful improvements, and that I reviewed the code
> (as well as I could) and didn't see any problems, I'm giving my ack
> anyway:

Tested every time I sent a patch

> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Thank you again

--
Federico Vaga