From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758414Ab3BFTvv (ORCPT ); Wed, 6 Feb 2013 14:51:51 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56649 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758389Ab3BFTvt (ORCPT ); Wed, 6 Feb 2013 14:51:49 -0500 Date: Wed, 6 Feb 2013 20:51:35 +0100 From: Jan Kara To: David Rientjes Cc: Jan Kara , Andrew Morton , LKML , jslaby@suse.cz, Greg Kroah-Hartman , Frederic Weisbecker , Steven Rostedt Subject: Re: [PATCH v2] printk: Avoid softlockups in console_unlock() Message-ID: <20130206195135.GA12117@quack.suse.cz> References: <1360016230-26696-1-git-send-email-jack@suse.cz> <20130205123838.146a5371.akpm@linux-foundation.org> <20130206142346.GF6330@quack.suse.cz> <20130206185205.GA11254@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 06-02-13 11:26:46, David Rientjes wrote: > On Wed, 6 Feb 2013, Jan Kara wrote: > > > On Wed 06-02-13 09:58:48, David Rientjes wrote: > > > On Wed, 6 Feb 2013, Jan Kara wrote: > > > > > > > Yes, I noticed that thread just yesterday and also though that using > > > > similar trick might be viable. I'll experiment if we could use the same > > > > method for handling lockup problems I hit. Steven seems to have already > > > > tweaked PRINTK_PENDING stuff to be usable more easily... > > > > > > > > > > Are these new build failures in linux-next coming from this patch? > > > > > > kernel/printk.c: In function 'console_unlock': > > > kernel/printk.c:2156:18: error: 'printk_work' undeclared (first use in this function) > > > kernel/printk.c:2156:18: note: each undeclared identifier is reported only once for each function it appears in > > > kernel/printk.c: At top level: > > > kernel/printk.c:2167:13: warning: 'printk_worker' defined but not used [-Wunused-function] > > Yes, I already sent a patch to fix these (attached if you need it). > > Thanks for notice. > > > > I don't see your attached > printk-Fixup-compilation-with-CONFIG_PRINTK.patch in -mm nor do I see it > on any mailing list. Regardless, Yeah, it was a private mail from kernel compilation testing guys with Andrew in CC. > Acked-by: David Rientjes Thanks. > for wherever Andrew has this stashed away. Thanks. Honza -- Jan Kara SUSE Labs, CR