From: Stephen Hemminger <stephen@networkplumber.org>
To: Freddy Xin <freddy@asix.com.tw>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver
Date: Wed, 6 Feb 2013 21:45:25 -0800 [thread overview]
Message-ID: <20130206214525.5c5775fe@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1360211794-4737-1-git-send-email-freddy@asix.com.tw>
On Thu, 7 Feb 2013 12:36:34 +0800
Freddy Xin <freddy@asix.com.tw> wrote:
> +struct {unsigned char ctrl, timer_l, timer_h, size, ifg; }
> +AX88179_BULKIN_SIZE[] = {
> + {7, 0x4f, 0, 0x12, 0xff},
> + {7, 0xf0, 1, 0x15, 0xff},
> + {7, 0xae, 7, 0x18, 0xff},
> + {7, 0xcc, 0x4c, 0x18, 8},
> +};
Better to make it static, const, and add a couple
of line breaks.
static const struct {
unsigned char ctrl, timer_l, timer_h, size, ifg;
} AX88179_BULKIN_SIZE[] = {
{7, 0x4f, 0, 0x12, 0xff},
{7, 0xf0, 1, 0x15, 0xff},
{7, 0xae, 7, 0x18, 0xff},
{7, 0xcc, 0x4c, 0x18, 8},
};
next prev parent reply other threads:[~2013-02-07 5:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 4:36 [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver Freddy Xin
2013-02-07 5:45 ` Stephen Hemminger [this message]
2013-02-07 6:45 ` Freddy
2013-02-07 5:46 ` Stephen Hemminger
2013-02-07 6:50 ` Freddy
-- strict thread matches above, loose matches on Subject: below --
2013-03-02 10:41 [PATCH " Freddy Xin
2013-03-03 6:44 ` David Miller
2013-02-27 12:01 Freddy Xin
2013-03-01 21:15 ` David Miller
2013-02-07 13:39 [PATCH, " Freddy Xin
2013-02-07 20:02 ` Ben Hutchings
2013-02-07 20:05 ` David Miller
2013-02-08 3:41 ` Freddy
2013-02-08 10:23 ` David Laight
2013-02-08 19:23 ` David Miller
2013-02-03 14:21 Daniel J Blueman
2013-12-04 12:48 ` Freddy
2013-01-23 2:32 Freddy Xin
2013-01-23 4:15 ` David Miller
2013-01-26 23:13 ` Michael Leun
2013-01-28 9:07 ` Bjørn Mork
2013-01-28 13:36 ` Freddy
2013-01-28 14:24 ` Bjørn Mork
2013-01-28 16:42 ` Michael Leun
2013-01-17 9:32 Freddy Xin
2013-01-18 19:23 ` David Miller
2013-01-18 20:29 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206214525.5c5775fe@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox