Re: [PATCH 13/13] workqueue: record global worker ID instead of pool ID in work->data when off-queue

Tejun Heo
2013-02-04T22:12:12Z

Hello,

One more thing.

On Fri, Feb 01, 2013 at 02:41:36AM +0800, Lai Jiangshan wrote:
> @@ -1216,7 +1198,11 @@ static int try_to_grab_pending(struct work_struct *work, bool is_dwork,
> list_del_init(&work->entry);
> cwq_dec_nr_in_flight(get_work_cwq(work), get_work_color(work));
>
> - clear_work_cwq(work, pool->id);
> + /* Does the work is still running? */
> + worker = find_worker_executing_work(pool, work);
> + worker_gwid = worker ? worker->gwid: WORK_OFFQ_WORKER_NONE;
> + clear_work_cwq(work, worker_gwid);

Any chance we can remove the busy_hash? Having to keep it around
isn't a big deal but it would be nice if can get rid of it.

Thanks.

--
tejun