Re: [PATCH 09/15] drivers/media: add missing GENERIC_HARDIRQS dependencies

Mauro Carvalho Chehab
2013-02-07T14:02:56Z

Em Wed, 6 Feb 2013 17:23:57 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> escreveu:

> The SuperH VEU mem2mem video processing driver (VIDEO_SH_VEU)
> calls devm_request_threaded_irq() and therefore should depend
> on GENERIC_HARDIRQS.
> Texas Instruments WL1273 I2C FM Radio (RADIO_WL1273) selects
> MFD_CORE, which itself depends on GENERIC_HARDIRQS.
> So add the dependency to the TI driver as well.
>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>

Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> drivers/media/platform/Kconfig | 2 +-
> drivers/media/radio/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 05d7b63..a0639e7 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -204,7 +204,7 @@ config VIDEO_SAMSUNG_EXYNOS_GSC
>
> config VIDEO_SH_VEU
> tristate "SuperH VEU mem2mem video processing driver"
> - depends on VIDEO_DEV && VIDEO_V4L2
> + depends on VIDEO_DEV && VIDEO_V4L2 && GENERIC_HARDIRQS
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> help
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index ead9928..24e64a0 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -192,7 +192,7 @@ config RADIO_TIMBERDALE
>
> config RADIO_WL1273
> tristate "Texas Instruments WL1273 I2C FM Radio"
> - depends on I2C && VIDEO_V4L2
> + depends on I2C && VIDEO_V4L2 && GENERIC_HARDIRQS
> select MFD_CORE
> select MFD_WL1273_CORE
> select FW_LOADER

--

Cheers,
Mauro