From: Andrew Morton <akpm@linux-foundation.org>
To: Jeremy Kerr <jk@ozlabs.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
Lingzhu Xiang <lxiang@redhat.com>, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH 1/3 v3] selftests: Add tests for efivarfs
Date: Thu, 7 Feb 2013 15:13:33 -0800 [thread overview]
Message-ID: <20130207151333.f01d415c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1360162088.143076.913706486688.1.gpush@pecola>
On Wed, 06 Feb 2013 22:48:08 +0800
Jeremy Kerr <jk@ozlabs.org> wrote:
> This change adds a few initial efivarfs tests to the
> tools/testing/selftests directory.
>
> The open-unlink test is based on code from
> Lingzhu Xiang <lxiang@redhat.com>.
>
> ...
>
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -1,4 +1,4 @@
> -TARGETS = breakpoints kcmp mqueue vm cpu-hotplug memory-hotplug
> +TARGETS = breakpoints kcmp mqueue vm cpu-hotplug memory-hotplug efivarfs
bah. This sort of Makefile construct is a wonderful source of patch
rejects and fixups. I'll covert this to
--- a/tools/testing/selftests/Makefile~a
+++ a/tools/testing/selftests/Makefile
@@ -1,4 +1,11 @@
-TARGETS = breakpoints epoll kcmp mqueue vm cpu-hotplug memory-hotplug efivarfs
+TARGETS = breakpoints
+TARGETS += epoll
+TARGETS += kcmp
+TARGETS += mqueue
+TARGETS += vm
+TARGETS += cpu-hotplug
+TARGETS += memory-hotplug
+TARGETS += efivarfs
all:
for TARGET in $(TARGETS); do \
> new file mode 100644
> index 0000000..1a943ee
> --- /dev/null
> +++ b/tools/testing/selftests/efivarfs/Makefile
> @@ -0,0 +1,12 @@
> +CC = $(CROSS_COMPILE)gcc
> +CFLAGS = -Wall
> +
> +test_objs = open-unlink
> +
> +all: $(test_objs)
> +
> +run_tests: all
> + @./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
Problem. When I apply the patch, ./efivarfs.sh doesn't have execute
permissions. I don't think there's a way of (reliably?) transporting
this with patch and diff.
So we should explicitly invoke sh or /bin/sh or $SHELL or whatever
here. This problem is common to several Makefiles in tools/testing/selftests/
I'll do this for now:
--- a/tools/testing/selftests/efivarfs/Makefile~selftests-add-tests-for-efivarfs-fix
+++ a/tools/testing/selftests/efivarfs/Makefile
@@ -6,7 +6,7 @@ test_objs = open-unlink
all: $(test_objs)
run_tests: all
- @./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
+ @/bin/sh ./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
clean:
rm -f $(test_objs)
but I'm not sure I did it right :(
The general ruleset for selftests is: do as much as you can if you're not
root and don't take too long and don't break the build on any
architecture and don't cause the top-level "make run_tests" to fail if
your feature is unconfigured.
Does this code pass all that?
next prev parent reply other threads:[~2013-02-07 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 14:48 [PATCH 0/3 v3] selftests: Add efivarfs tests Jeremy Kerr
2013-02-06 14:48 ` [PATCH 2/3 v3] selftests/efivarfs: Add empty file creation test Jeremy Kerr
2013-02-06 14:48 ` [PATCH 1/3 v3] selftests: Add tests for efivarfs Jeremy Kerr
2013-02-07 23:13 ` Andrew Morton [this message]
2013-02-08 10:02 ` [PATCH] Documentation: Add a simple doc for selftests Jeremy Kerr
2013-02-12 23:56 ` Andrew Morton
2013-02-08 10:05 ` [PATCH 1/3 v3] selftests: Add tests for efivarfs Jeremy Kerr
2013-02-08 10:08 ` Matt Fleming
2013-02-12 23:50 ` Andrew Morton
2013-02-13 7:32 ` Matt Fleming
2013-02-12 23:48 ` Andrew Morton
2013-02-06 14:48 ` [PATCH 3/3 v3] selftests/efivarfs: Add create-read test Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207151333.f01d415c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lxiang@redhat.com \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox