From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: J Keerthy <j-keerthy@ti.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function
Date: Fri, 8 Feb 2013 11:28:48 +0000 [thread overview]
Message-ID: <20130208112848.GM8879@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1359695098-3630-1-git-send-email-j-keerthy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
On Fri, Feb 01, 2013 at 10:34:58AM +0530, J Keerthy wrote:
> +++ b/drivers/regulator/core.c
> @@ -81,6 +81,8 @@ struct regulator {
> int uA_load;
> int min_uV;
> int max_uV;
> + int curr_min_uV;
> + int curr_max_uV;
This change makes sense but I don't see why we need to add these to
struct regulator - why not just store the values locally for unwinding?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-08 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 5:04 [PATCH] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function J Keerthy
2013-02-04 11:53 ` J, KEERTHY
2013-02-04 15:05 ` Mark Brown
2013-02-08 11:28 ` Mark Brown [this message]
2013-02-11 5:26 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208112848.GM8879@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox