From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Joe Perches <joe@perches.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: memcmp_nta: add timing-attack secure memcmp
Date: Sun, 10 Feb 2013 15:50:57 -0800 [thread overview]
Message-ID: <20130210235057.GA5485@kroah.com> (raw)
In-Reply-To: <51182DAB.1030708@redhat.com>
On Mon, Feb 11, 2013 at 12:30:51AM +0100, Daniel Borkmann wrote:
> On 02/11/2013 12:24 AM, Joe Perches wrote:
> >On Sun, 2013-02-10 at 23:00 +0100, Daniel Borkmann wrote:
> >>add memcmp_nta ({n}o {t}iming {a}ttacks)
> >
> >Why should this be in the kernel?
>
> As the commit message already says, so that current or future (e.g.) network
> protocol code or modules can make use of this when dealing with cryptographic
> hash comparisons.
Do we have any in-kernel users that need this? If not, then don't add
it now, but rather, add it when we actually have a user. We almost
never add kernel functions that no one calls, that would be just
wasteful.
sorry,
greg k-h
next prev parent reply other threads:[~2013-02-10 23:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1360528614.git.dborkman@redhat.com>
2013-02-10 22:00 ` [PATCH] lib: memcmp_nta: add timing-attack secure memcmp Daniel Borkmann
2013-02-10 23:24 ` Joe Perches
2013-02-10 23:30 ` Daniel Borkmann
2013-02-10 23:50 ` Greg KH [this message]
2013-02-11 8:19 ` Daniel Borkmann
2013-02-11 18:37 ` Andy Lutomirski
2013-02-11 19:39 ` Daniel Borkmann
2013-02-11 19:00 ` Florian Weimer
2013-02-11 22:58 ` Daniel Borkmann
2013-02-12 10:23 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210235057.GA5485@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dborkman@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox