Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master

Grant Likely
2013-02-12T18:19:22Z

On Tue, 12 Feb 2013 10:39:02 +0100, Andreas Larsson <andreas@gaisler.com> wrote:
> On 2013-02-11 01:22, Grant Likely wrote:
> > On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson <andreas@gaisler.com> wrote:
> >> When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs to be
> >> known to the controller driver.
> >>
> >> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
> >
> > Out of curiosity, what do you need the flags for? Polarity of the CS
> > signal? I think it is long past time to revisit baking polarity control
> > into core of gpiolib. Would you mind investigating doing that instead of
> > having to manage it manually in each and every driver?
>
> I don't even need it on my hardware. It seemed like a good thing to have
> via of_spi_register_master. I am OK with just dropping this.

Hahaha. Okay, let's leave it for now until someone does need it. I can
however see the need for the polarity flag, so the request still stands
for someone to put that feature into the core. :-)

g.

--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.