From: Gleb Natapov <gleb@redhat.com>
To: Shuah Khan <shuah.khan@hp.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
avi@redhat.com, mtosatti@redhat.com, mst@redhat.com,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, shuahkhan@gmail.com
Subject: Re: [PATCH linux-next] x86/kvm: Fix compile warning in kvm_register_steal_time()
Date: Mon, 11 Feb 2013 11:06:26 +0200 [thread overview]
Message-ID: <20130211090626.GV7837@redhat.com> (raw)
In-Reply-To: <1360119442.8356.8.camel@lorien2>
On Tue, Feb 05, 2013 at 07:57:22PM -0700, Shuah Khan wrote:
> Fix the following compile warning in kvm_register_steal_time():
> CC arch/x86/kernel/kvm.o
> arch/x86/kernel/kvm.c: In function ‘kvm_register_steal_time’:
> arch/x86/kernel/kvm.c:302:3: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘phys_addr_t’ [-Wformat]
>
Ingo, the warning is from the tip tree. Can you take the fix?
> Signed-off-by: Shuah Khan <shuah.khan@hp.com>
> ---
> arch/x86/kernel/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index fe75a28..b686a90 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -298,8 +298,8 @@ static void kvm_register_steal_time(void)
> memset(st, 0, sizeof(*st));
>
> wrmsrl(MSR_KVM_STEAL_TIME, (slow_virt_to_phys(st) | KVM_MSR_ENABLED));
> - printk(KERN_INFO "kvm-stealtime: cpu %d, msr %lx\n",
> - cpu, slow_virt_to_phys(st));
> + pr_info("kvm-stealtime: cpu %d, msr %llx\n",
> + cpu, (unsigned long long) slow_virt_to_phys(st));
> }
>
> static DEFINE_PER_CPU(unsigned long, kvm_apic_eoi) = KVM_PV_EOI_DISABLED;
> --
> 1.7.9.5
>
>
--
Gleb.
next prev parent reply other threads:[~2013-02-11 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 2:57 [PATCH linux-next] x86/kvm: Fix compile warning in kvm_register_steal_time() Shuah Khan
2013-02-11 9:06 ` Gleb Natapov [this message]
2013-02-11 10:04 ` Ingo Molnar
2013-02-11 10:05 ` Gleb Natapov
2013-02-11 10:06 ` Ingo Molnar
2013-02-11 12:36 ` [tip:x86/mm] " tip-bot for Shuah Khan
2013-02-13 14:35 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211090626.GV7837@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox