From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755209Ab3BKKJq (ORCPT ); Mon, 11 Feb 2013 05:09:46 -0500 Received: from mga03.intel.com ([143.182.124.21]:6025 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754907Ab3BKKJp (ORCPT ); Mon, 11 Feb 2013 05:09:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,641,1355126400"; d="scan'208";a="201018814" Date: Mon, 11 Feb 2013 12:13:36 +0200 From: Mika Westerberg To: Benjamin Tissoires Cc: Dmitry Torokhov , Henrik Rydberg , Jiri Kosina , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] hid driver transport cleanup Message-ID: <20130211101336.GA20771@intel.com> References: <1360334256-22127-1-git-send-email-benjamin.tissoires@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1360334256-22127-1-git-send-email-benjamin.tissoires@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 08, 2013 at 03:37:29PM +0100, Benjamin Tissoires wrote: > so, here is the hid drivers cleanup. The aim is to remove as much as possible > direct calls to usbhid for hid drivers. Thus, other transport layers can use > the existing hid drivers (like I2C or uhid). We also found out that there is a dependency to usbhid in many of the drivers, especially in sensor-hub which caused the system crash while the driver tried to transmit over USB even though it was behind I2C. Your series fixes that nicely :) You can add, Reviewed-by: Mika Westerberg for the whole series and in addition, Tested-by: Mika Westerberg for the sensor-hub part (HID over I2C). I have few more patches to the sensor-hub myself and I'm going to rebase them on top of this series.