public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel <devel@driverdev.osuosl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: Remove unnecessary OOM messages
Date: Mon, 11 Feb 2013 10:14:28 -0800	[thread overview]
Message-ID: <20130211181428.GA21288@kroah.com> (raw)
In-Reply-To: <1360604489.2028.25.camel@joe-AO722>

On Mon, Feb 11, 2013 at 09:41:29AM -0800, Joe Perches wrote:
> alloc failures already get standardized OOM
> messages and a dump_stack.
> 
> For the affected mallocs around these OOM messages:
> 
> Converted kzallocs with multiplies to kcalloc.
> Converted kmallocs with multiplies to kmalloc_array.
> Converted a kmalloc/strlen/strncpy to kstrdup.
> Moved a spin_lock below a removed OOM message and
> removed a now unnecessary spin_unlock.
> Neatened alignment and whitespace.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/staging/asus_oled/asus_oled.c              | 15 ++-----
>  drivers/staging/bcm/InterfaceInit.c                | 14 ++----
>  drivers/staging/ced1401/usb1401.c                  |  4 +-
>  drivers/staging/comedi/drivers.c                   |  5 +--
>  drivers/staging/comedi/drivers/amplc_dio200.c      |  9 ++--
>  drivers/staging/comedi/drivers/comedi_bond.c       |  5 +--
>  drivers/staging/comedi/drivers/dt9812.c            |  5 +--
>  drivers/staging/comedi/drivers/ni_labpc.c          | 10 ++---
>  drivers/staging/comedi/drivers/pcmuio.c            | 11 ++---
>  drivers/staging/comedi/drivers/unioxx5.c           |  6 +--
>  drivers/staging/comedi/drivers/usbdux.c            | 27 ++----------
>  drivers/staging/comedi/drivers/usbduxfast.c        |  6 ---
>  drivers/staging/comedi/drivers/usbduxsigma.c       | 31 +++----------
>  drivers/staging/cptm1217/clearpad_tm1217.c         |  5 +--
>  drivers/staging/et131x/et131x.c                    | 20 +++------
>  drivers/staging/frontier/alphatrack.c              | 51 +++++++++-------------
>  drivers/staging/frontier/tranzport.c               | 26 +++++------
>  drivers/staging/ft1000/ft1000-usb/ft1000_usb.c     |  5 +--
>  drivers/staging/gdm72xx/gdm_sdio.c                 |  8 +---
>  drivers/staging/gdm72xx/sdio_boot.c                |  9 +---
>  drivers/staging/gdm72xx/usb_boot.c                 |  8 +---
>  drivers/staging/iio/accel/lis3l02dq_ring.c         |  5 +--
>  drivers/staging/keucr/usb.c                        |  5 +--
>  drivers/staging/line6/driver.c                     | 25 ++---------
>  drivers/staging/line6/pcm.c                        |  6 ---
>  drivers/staging/media/as102/as102_usb_drv.c        |  4 +-
>  drivers/staging/media/go7007/go7007-fw.c           | 24 +++-------
>  drivers/staging/media/go7007/s2250-loader.c        |  5 +--
>  drivers/staging/media/lirc/lirc_imon.c             |  3 --
>  drivers/staging/media/lirc/lirc_sasem.c            |  6 ---

I cut the drivers/staging/media/* patches out of this larger patch as
those need to go through Mauro's tree, not mine (they also don't apply
to mine because of that.)

thanks,

greg k-h

      reply	other threads:[~2013-02-11 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 17:41 [PATCH] staging: Remove unnecessary OOM messages Joe Perches
2013-02-11 18:14 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130211181428.GA21288@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox