From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.jf.intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>,
Mika Westerberg <mika.westerberg@linux.jf.intel.com>
Subject: Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers
Date: Tue, 12 Feb 2013 08:10:18 -0800 [thread overview]
Message-ID: <20130212161018.GN3789@intel.com> (raw)
In-Reply-To: <CAHp75Vc7Y4uLKmBuK5p9O75qEfBjckmEtxmNQLmn7WFNsOBEjw@mail.gmail.com>
On Fri, Feb 08, 2013 at 09:25:11AM +0200, Andy Shevchenko wrote:
> On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> >> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >>> On 7 February 2013 21:06, Andy Shevchenko
> >>> <andriy.shevchenko@linux.intel.com> wrote:
> >>>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> ...
> >>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >>>
> >>> Looks like Mika is Author and you have your signed-off :)
> >>
> >> In this literally small and clear patch it doesn't matter who is who.
> >
> > I believe it doesn't matter how small or big is the patch, but the author should
> > be there in SOBs too..
> True.
Then in that case you need to re-read Documentation/SubmittingPatches
SOB is also acnowlegement of Origin of the Code, hence mandatory even for single
line of change.
> >
> >> However for sake of equity I could add Mika's signed-off-by as well.
> >>
> >> It should be:
> >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Thanks.
>
> Shall I resend it?
It will fix it up, and thanks to greg now you owe me a beverage :)
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2013-02-12 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 15:36 [PATCH] dw_dmac: add support for Lynxpoint DMA controllers Andy Shevchenko
2013-02-07 15:39 ` Viresh Kumar
2013-02-07 17:05 ` Andy Shevchenko
2013-02-08 4:28 ` Viresh Kumar
2013-02-08 7:25 ` Andy Shevchenko
2013-02-08 7:30 ` Viresh Kumar
2013-02-12 16:10 ` Vinod Koul [this message]
2013-02-12 16:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212161018.GN3789@intel.com \
--to=vinod.koul@intel.com \
--cc=andriy.shevchenko@linux.jf.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.jf.intel.com \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox