[PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Andy Shevchenko]

From: Mika Westerberg <mika.westerberg@linux.intel.com>

Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
from ACPI namespace with ACPI ID INTL9C60.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/dw_dmac.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index d6abea8..5feee76 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1977,6 +1977,11 @@ static const struct of_device_id dw_dma_id_table[] = {
 MODULE_DEVICE_TABLE(of, dw_dma_id_table);
 #endif
 
+static const struct platform_device_id dw_dma_ids[] = {
+	{ "INTL9C60", 0 },
+	{ }
+};
+
 static struct platform_driver dw_driver = {
 	.probe		= dw_probe,
 	.remove		= dw_remove,
@@ -1986,6 +1991,7 @@ static struct platform_driver dw_driver = {
 		.pm	= &dw_dev_pm_ops,
 		.of_match_table = of_match_ptr(dw_dma_id_table),
 	},
+	.id_table	= dw_dma_ids,
 };
 
 static int __init dw_init(void)
-- 
1.7.10.4

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Viresh Kumar]

On 7 February 2013 21:06, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
> purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
> from ACPI namespace with ACPI ID INTL9C60.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Looks like Mika is Author and you have your signed-off :)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Andy Shevchenko]

On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 7 February 2013 21:06, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
>> purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
>> from ACPI namespace with ACPI ID INTL9C60.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Looks like Mika is Author and you have your signed-off :)

In this literally small and clear patch it doesn't matter who is who.
However for sake of equity I could add Mika's signed-off-by as well.

It should be:
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>


> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Viresh Kumar]

On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> On 7 February 2013 21:06, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>>
>>> Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
>>> purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
>>> from ACPI namespace with ACPI ID INTL9C60.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Looks like Mika is Author and you have your signed-off :)
>
> In this literally small and clear patch it doesn't matter who is who.

I believe it doesn't matter how small or big is the patch, but the author should
be there in SOBs too..

> However for sake of equity I could add Mika's signed-off-by as well.
>
> It should be:
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks.

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Andy Shevchenko]

On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>> On 7 February 2013 21:06, Andy Shevchenko
>>> <andriy.shevchenko@linux.intel.com> wrote:
>>>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
...
>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>
>>> Looks like Mika is Author and you have your signed-off :)
>>
>> In this literally small and clear patch it doesn't matter who is who.
>
> I believe it doesn't matter how small or big is the patch, but the author should
> be there in SOBs too..
True.
>
>> However for sake of equity I could add Mika's signed-off-by as well.
>>
>> It should be:
>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Thanks.

Shall I resend it?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Viresh Kumar]

On Fri, Feb 8, 2013 at 12:55 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> Shall I resend it?

Naah!! Vinod can manage it, i believe :)

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Vinod Koul]

On Fri, Feb 08, 2013 at 09:25:11AM +0200, Andy Shevchenko wrote:
> On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> >> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >>> On 7 February 2013 21:06, Andy Shevchenko
> >>> <andriy.shevchenko@linux.intel.com> wrote:
> >>>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> ...
> >>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >>>
> >>> Looks like Mika is Author and you have your signed-off :)
> >>
> >> In this literally small and clear patch it doesn't matter who is who.
> >
> > I believe it doesn't matter how small or big is the patch, but the author should
> > be there in SOBs too..
> True.
Then in that case you need to re-read Documentation/SubmittingPatches
SOB is also acnowlegement of Origin of the Code, hence mandatory even for single
line of change.
> >
> >> However for sake of equity I could add Mika's signed-off-by as well.
> >>
> >> It should be:
> >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Thanks.
> 
> Shall I resend it?
It will fix it up, and thanks to greg now you owe me a beverage :)
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

[Vinod Koul]

On Thu, Feb 07, 2013 at 05:36:28PM +0200, Andy Shevchenko wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
> purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
> from ACPI namespace with ACPI ID INTL9C60.
> 
Applied with correct SOBs...

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/dma/dw_dmac.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index d6abea8..5feee76 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -1977,6 +1977,11 @@ static const struct of_device_id dw_dma_id_table[] = {
>  MODULE_DEVICE_TABLE(of, dw_dma_id_table);
>  #endif
>  
> +static const struct platform_device_id dw_dma_ids[] = {
> +	{ "INTL9C60", 0 },
> +	{ }
> +};
> +
>  static struct platform_driver dw_driver = {
>  	.probe		= dw_probe,
>  	.remove		= dw_remove,
> @@ -1986,6 +1991,7 @@ static struct platform_driver dw_driver = {
>  		.pm	= &dw_dev_pm_ops,
>  		.of_match_table = of_match_ptr(dw_dma_id_table),
>  	},
> +	.id_table	= dw_dma_ids,
>  };
>  
>  static int __init dw_init(void)
> -- 
> 1.7.10.4
>