From: Vinod Koul <vinod.koul@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: djbw@fb.com, maciej.patelczyk@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ioatdma: fix race between updating ioat->head and IOAT_COMPLETION_PENDING
Date: Tue, 12 Feb 2013 08:28:02 -0800 [thread overview]
Message-ID: <20130212162802.GQ3789@intel.com> (raw)
In-Reply-To: <20130207213832.13721.36522.stgit@djiang5-linux2.ch.intel.com>
On Thu, Feb 07, 2013 at 02:38:32PM -0700, Dave Jiang wrote:
> There is a race that can hit during __cleanup() when the ioat->head pointer is
> incremented during descriptor submission. The __cleanup() can clear the
> PENDING flag when it does not see any active descriptors. This causes new
> submitted descriptors to be ignored because the COMPLETION_PENDING flag is
> cleared. This was introduced when code was adapted from ioatdma v1 to ioatdma
> v2. For v2 and v3, IOAT_COMPLETION_PENDING flag will be abandoned and a new
> flag IOAT_CHAN_ACTIVE will be utilized. This flag will also be protected under
> the prep_lock when being modified in order to avoid the race.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Dan Williams <djbw@fb.com>
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2013-02-12 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 21:38 [PATCH] ioatdma: fix race between updating ioat->head and IOAT_COMPLETION_PENDING Dave Jiang
2013-02-12 16:28 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212162802.GQ3789@intel.com \
--to=vinod.koul@intel.com \
--cc=dave.jiang@intel.com \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.patelczyk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox