From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Ian Abbott <abbotti@mev.co.uk>,
devel@driverdev.osuosl.org,
Mori Hess <fmhess@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/comedi: Fix undefined array subscript
Date: Wed, 13 Feb 2013 10:32:14 +0300 [thread overview]
Message-ID: <20130213073214.GR4937@mwanda> (raw)
In-Reply-To: <1360726254-7895-1-git-send-email-peterhuewe@gmx.de>
On Wed, Feb 13, 2013 at 04:30:54AM +0100, Peter Huewe wrote:
> In vmk80xx_do_insn_bits the local variable reg, which is used as an
> index to the tx_buf array, can be used uninitialized if
> - data[0] == 0
> and
> - devpriv->model != VMK8061_MODEL
> -> we get into the else branch without having reg initialized.
It's weird that GCC doesn't warn about this...
This patch works, or at least it doesn't break anything that wasn't
already broken, but it doesn't feel like the right thing. Probably
we could move the reg setting outside the if statement.
if (devpriv->model == VMK8055_MODEL) {
reg = VMK8055_DO_REG;
cmd = VMK8055_CMD_WRT_AD;
} else { /* VMK8061_MODEL */
reg = VMK8061_DO_REG;
cmd = VMK8061_CMD_DO;
}
if (data[0]) {
tx_buf[reg] &= ~data[0];
Or maybe data[0] == 0 needs to be handled differently.
Ian would know for sure.
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-13 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 3:30 [PATCH] staging/comedi: Fix undefined array subscript Peter Huewe
2013-02-13 7:32 ` Dan Carpenter [this message]
2013-02-13 11:56 ` Ian Abbott
2013-02-13 13:47 ` Ian Abbott
2013-02-13 14:01 ` Dan Carpenter
2013-02-13 14:28 ` [PATCH v2] " Peter Huewe
2013-02-13 14:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213073214.GR4937@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox