From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
boris.ostrovsky@amd.com, tglx@linutronix.de, hpa@linux.intel.com,
linux-tip-commits@vger.kernel.org,
Sasha Levin <sasha.levin@oracle.com>, Asias He <asias@redhat.com>
Subject: Re: [tip:x86/cpu] x86, AMD: Enable WC+ memory type on family 10 processors
Date: Wed, 13 Feb 2013 12:16:27 +0400 [thread overview]
Message-ID: <20130213081627.GL22249@moon> (raw)
In-Reply-To: <CAOJsxLH71KTFbkm5h9AuquC04cJ0NmtCiUjSevkxqLYRBPPi8g@mail.gmail.com>
On Wed, Feb 13, 2013 at 10:06:25AM +0200, Pekka Enberg wrote:
> On Wed, Feb 13, 2013 at 2:21 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> >>> + rdmsrl(MSR_AMD64_BU_CFG2, value);
> >>> + value &= ~(1ULL << 24);
> >>> + wrmsrl(MSR_AMD64_BU_CFG2, value);
> >>> + }
> >>> }
> >>>
> >>> rdmsr_safe(MSR_AMD64_PATCH_LEVEL, &c->microcode, &dummy);
> >>
> >>
> >> However, the more serious issue is that that same kernel #GPs when
> >> booted in kvm. It seems it cannot stomach that specific MSR, see the
> >> second "<-- trapping instruction" below and that BU_CFG2 MSR landing in
> >> %ecx in the line before that.
> >>
> >> Oh, and this happens only with the kvm executable (/usr/bin/kvm) in
> >> debian testing. If I use qemu from git, it passes over init_amd just
> >> fine.
> >>
> >> Hmmm..
> >
> > It #GPs on an MSR, which tends to be a bug in the VMM; RDMSR/WRMSR generally
> > kick out to the VMM. There isn't a huge lot of work we can do about that...
> >
> > I think Qemu defaults to ignoring unknown-to-it MSRs whereas maybe kvmtool
> > croaks? Pekka?
>
> I think we should also be fine. Cyrill?
Never was #gp on unknown msr register access, so I think
we're safe. But maybe Borislav may give lkvm a shot just
to be sure?
prev parent reply other threads:[~2013-02-13 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 21:32 [PATCH 2/2] x86,AMD: Enable WC+ memory type on family 10 processors Boris Ostrovsky
2013-01-31 22:45 ` [tip:x86/cpu] x86, AMD: " tip-bot for Boris Ostrovsky
2013-02-13 0:16 ` Borislav Petkov
2013-02-13 0:21 ` H. Peter Anvin
2013-02-13 0:31 ` Borislav Petkov
2013-02-13 8:06 ` Pekka Enberg
2013-02-13 8:16 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213081627.GL22249@moon \
--to=gorcunov@openvz.org \
--cc=asias@redhat.com \
--cc=boris.ostrovsky@amd.com \
--cc=bp@alien8.de \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penberg@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox