From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894Ab3BMJVI (ORCPT ); Wed, 13 Feb 2013 04:21:08 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:44276 "EHLO mail-ee0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778Ab3BMJVF (ORCPT ); Wed, 13 Feb 2013 04:21:05 -0500 Date: Wed, 13 Feb 2013 10:21:01 +0100 From: Ingo Molnar To: anish singh Cc: akpm@linux-foundation.org, dzickus@redhat.com, tglx@linutronix.de, chuansheng.liu@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable Message-ID: <20130213092101.GD7630@gmail.com> References: <1359907275-15410-1-git-send-email-anish198519851985@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * anish singh wrote: > Is the below patch picked up? > > On Sun, Feb 3, 2013 at 9:31 PM, anish kumar wrote: > > From: anish kumar > > > > This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. > > Uses are: > > 1. Check if smpboot_register_percpu_thread function passed. > > 2. Makes sure that user enables and disables the watchdog in sequence > > i.e. enable watchdog->disable watchdog->enable watchdog > > Unlike enable watchdog->enable watchdog which is wrong. > > > > Signed-off-by: anish kumar > > --- > > kernel/watchdog.c | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > > index 75a2ab3..87a19aa 100644 > > --- a/kernel/watchdog.c > > +++ b/kernel/watchdog.c > > @@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write, > > return ret; > > > > set_sample_period(); > > + /* > > + * We shouldn't enable watchdog threads if it is > > + * disabled.This is done by watchdog_disabled > > + * variable check in watchdog_*_all_cpus function. It has two grammatic and a stylistic error in it, plus misses the convention that function names are mentioned with a '()'. Thanks, Ingo