From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Ian Abbott <ian.abbott@mev.co.uk>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Mori Hess <fmhess@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/comedi: Fix undefined array subscript
Date: Wed, 13 Feb 2013 17:01:47 +0300 [thread overview]
Message-ID: <20130213140147.GA4606@mwanda> (raw)
In-Reply-To: <511B995E.3030905@mev.co.uk>
This patch works but it's nasty to re-intialize "reg" inside both
if else statements. Just do it once at the begining of the
function.
That means we would also delete the ininitialization from the if
side of the if else statement:
if (devpriv->model == VMK8061_MODEL) {
- reg = VMK8061_DO_REG;
tx_buf[0] = VMK8061_CMD_RD_DO;
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-13 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 3:30 [PATCH] staging/comedi: Fix undefined array subscript Peter Huewe
2013-02-13 7:32 ` Dan Carpenter
2013-02-13 11:56 ` Ian Abbott
2013-02-13 13:47 ` Ian Abbott
2013-02-13 14:01 ` Dan Carpenter [this message]
2013-02-13 14:28 ` [PATCH v2] " Peter Huewe
2013-02-13 14:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213140147.GA4606@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox