From: Damien Wyart <damien.wyart@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
peterz@infradead.org, mingo@kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] sched: fix env->src_cpu for active migration
Date: Wed, 13 Feb 2013 15:08:43 +0100 [thread overview]
Message-ID: <20130213140843.GA21308@brouette> (raw)
In-Reply-To: <CAKfTPtDprVAA0o6sTugYk8RiaUkGXUmSvd4RJbTEhNkKj7B-5A@mail.gmail.com>
* Vincent Guittot <vincent.guittot@linaro.org> [2013-02-13 13:08]:
> Damien,
> Regarding your sched_domain config and especially the flags field, you
> should not be impacted by my patch because
> - need_active_balance is the only new place that use env->src_cpu in
> the load_balance function
> - and your machine will never test the condition: "env->src_cpu >
> env->dst_cpu" in need_active_balance because SD_ASYM_PACKING is not
> set in your config
> Have you tested the patch with others that could have modified the
> load_balance function ?
Yes, sorry, I should have been more precise in my initial report: your
patch was not applied on top of vanilla 3.8-rc7, but a few other patches
were also present. Seems the ones impacting load_balance are from
Frederic's nohz work
(http://git.kernel.org/?p=linux/kernel/git/frederic/linux-dynticks.git;a=shortlog;h=refs/heads/3.8-rc6-nohz4)
The patches from there modifying load_balance are:
- "sched: Update nohz rq clock before searching busiest group on load balancing"
- "sched: Update clock of nohz busiest rq before balancing"
In this test, I did not use any kernel parameter related to this
patchset (full_nohz, etc.).
I am adding Frederic in Cc, not sure if the breakage is to be
investigated on your side or his...
Thanks for your explanations,
--
Damien
next prev parent reply other threads:[~2013-02-13 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 13:19 [PATCH] sched: fix env->src_cpu for active migration Vincent Guittot
2013-02-13 6:18 ` Damien Wyart
2013-02-13 7:54 ` Vincent Guittot
2013-02-13 9:21 ` Damien Wyart
2013-02-13 12:08 ` Vincent Guittot
2013-02-13 14:08 ` Damien Wyart [this message]
2013-02-13 14:28 ` Vincent Guittot
2013-02-13 17:49 ` Vincent Guittot
2013-02-13 18:47 ` Damien Wyart
2013-02-13 20:02 ` Damien Wyart
2013-02-14 8:32 ` Vincent Guittot
2013-02-13 20:03 ` Paul Turner
2013-02-14 13:37 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213140843.GA21308@brouette \
--to=damien.wyart@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox