The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2] regmap: debugfs: Simplify calculation of `c->max_reg'
Date: Thu, 14 Feb 2013 14:37:51 +0000	[thread overview]
Message-ID: <20130214143751.GA23599@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130214141439.GL13249@opensource.wolfsonmicro.com>

On Thu, Feb 14, 2013 at 02:14:40PM +0000, Mark Brown wrote:
> On Thu, Feb 14, 2013 at 02:04:04PM +0000, Dimitris Papastamos wrote:
> 
> > -	unsigned int i, ret;
> > +	unsigned int i = 0, ret;
> 
> Coding style and are you sure this is a good default.

Hm, it doesn't really matter.  I guess the proper fix would
be to set i = base at the start, but that would not change
anything in terms of the actual code flow, it would only silence
the gcc flow analysis bug.

Thanks,
Dimitris

      reply	other threads:[~2013-02-14 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 14:04 [PATCH v2] regmap: debugfs: Simplify calculation of `c->max_reg' Dimitris Papastamos
2013-02-14 14:14 ` Mark Brown
2013-02-14 14:37   ` Dimitris Papastamos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214143751.GA23599@opensource.wolfsonmicro.com \
    --to=dp@opensource.wolfsonmicro.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox