Re: fb: mmp: include linux/platform_device.h

Haojian Zhuang
2013-02-17T15:45:36Z

On Fri, Feb 15, 2013 at 10:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Patch 16559ae "kgdb: remove #include <linux/serial_8250.h> from kgdb.h"
> changes the kgdb.h file so that drivers including it do not implicitly
> include linux/platform_device.h. The mmp framebuffer driver is new,
> so Greg did not have a chance to fix it up when introducing his change.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> On Thursday 14 February 2013, Greg Kroah-Hartman wrote:
>> On Thu, Feb 14, 2013 at 11:26:56PM +0100, Arnd Bergmann wrote:
>> > Patch 16559ae "kgdb: remove #include <linux/serial_8250.h> from kgdb.h"
>> > removed an implicit inclusion of linux/platform_device.h
>> > In a number of places. This adds back explicit inclusions in a few
>> > more places I found.
>>
>> > drivers/video/mmp/fb/mmpfb.c | 1 +
>>
>> This file isn't my tty tree, so I can't apply that part of the patch,
>> but I've applied the rest of the patch, and the 2 others you sent me to
>> fix this issue.
>
> Right. It seems the driver is only in Andrew's tree. Andrew, can you
> add this hunk on top?
>
> diff --git a/drivers/video/mmp/fb/mmpfb.c b/drivers/video/mmp/fb/mmpfb.c
> index f34a3a9..6d1fa96 100644
> --- a/drivers/video/mmp/fb/mmpfb.c
> +++ b/drivers/video/mmp/fb/mmpfb.c
> @@ -21,6 +21,7 @@
> */
> #include <linux/module.h>
> #include <linux/dma-mapping.h>
> +#include <linux/platform_device.h>
> #include "mmpfb.h"
>
> static int var_to_pixfmt(struct fb_var_screeninfo *var)

Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>