Re: [PATCH] Various cleanups/fixes to zcache (v3).

Greg KH
2013-02-14T17:29:31Z

On Thu, Feb 14, 2013 at 09:02:47AM -0800, Dan Magenheimer wrote:
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Subject: Re: [PATCH] Various cleanups/fixes to zcache (v3).
> >
> > On Thu, Feb 14, 2013 at 08:56:01AM -0800, Dan Magenheimer wrote:
> > > > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > >
> > > > From Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> # This line is ignored.
> > > > From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > > In-Reply-To:
> > > >
> > > > Hey Greg,
> > > >
> > > > These patches do various cleanups of the zcache driver. The majority of the
> > > > work is just to move all the different counters out to a debug file. The next
> > > > step would be to figure out which ones are actually pertient and which can
> > > > go under the knife. Oh, and also fix some of the compiler warnings.
> > > >
> > > > This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
> > > > ("staging/zcache: Fix/improve zcache writeback code, tie to a config option")
> > > > so should apply cleanly to your tree.
> > > >
> > > > Please apply.
> > >
> > > Useful cleanups.
> > >
> > > Hopefully not too late for 3.9-rc0.
> >
> > You all did see my "the staging tree is closed except for bugfixes for
> > 3.9" message last week, right?
>
> Oops, sorry, no I missed that.
>
> > Sorry, this will have to wait for 3.10.
>
> No problem, no bugs fixed here, though I expect we'll see
> the same complaints posted again about the compiler warnings.

Then why not just redo that one patch, and send it to me, and then
rebase all of the other patches on top of it? That way I can accept the
"fix the complier warnings" patch now, and the rest can wait.

thanks,

greg k-h